LayoutTests/webaudio/audiocontext-max-contexts.html - Issue 27037002: Get rid of custom bindings for AudioContext's constructor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/webaudio/audiocontext-max-contexts.html

Issue 27037002: Get rid of custom bindings for AudioContext's constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Throw exception when max number of hardware contexts is reached Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../fast/js/resources/js-test-pre.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description("Check that the AudioContext constructor throws when the limit on ha rdware contexts is reached.");

	9

	10 function reachHardwareContextsLimit() {

	11 var context = [];

	12 for (var i=0; i<10; ++i) {

	13 context[i] = new webkitAudioContext();

	14 // Trigger lazy initialization.

	15 context[i].createBufferSource();

	16 }

	17 }

	18

	19 shouldThrow("reachHardwareContextsLimit()");
	Ken Russell (switch to Gerrit) 2013/10/11 19:19:01 Is this test really viable? What if the implementa Is this test really viable? What if the implementation is clever and can support, say, 100 simultaneous contexts, all software-mixed together? Inactive 2013/10/11 19:29:49 This is currently hardcoded in Blink so this is no Show quoted text On 2013/10/11 19:19:01, Ken Russell wrote: > Is this test really viable? What if the implementation is clever and can > support, say, 100 simultaneous contexts, all software-mixed together? This is currently hardcoded in Blink so this is not currently a problem and it is deterministic. If the situation changes and it becomes hard to test, we may have to get rid of this test at some point. However, in the mean time I think it adds some coverage, which is valuable. As you can see, my first patch set was wrong and I did not notice because of lack of test coverage. That said, if you prefer I remove the test (or if you have a better idea how to test it), I won't mind.
	20 </script>

	21 <script src="../fast/js/resources/js-test-post.js"></script>

	22 </body>

	23 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/webaudio/audiocontext-max-contexts-expected.txt » ('j') | no next file with comments »