chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js - Issue 2703663002: Display images in multiline Braille

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js

Issue 2703663002: Display images in multiline Braille (Closed)

Patch Set: Final feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js b/chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js

index e108c68ee4f52053efe5bc8b6113ebd102617fd5..9d411ff0083c7c00b9bd9e5d6d946e7d2ad11289 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js

@@ -127,6 +127,7 @@ cvox.BrailleKeyEvent.legacyKeyCodeMap_ = {

/**

* The state of a braille display as represented in the

* chrome.brailleDisplayPrivate API.

- * @typedef {{available: boolean, textCellCount: (number|undefined)}}

+ * @typedef {{available: boolean, textRowCount: number,

+ * textColumnCount: number}}

cvox.BrailleDisplayState;