third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl - Issue 2703653004: [WebAgentsAPI]: Start adding support for method arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl

Issue 2703653004: [WebAgentsAPI]: Start adding support for method arguments. (Closed)

Patch Set: Comments addressed. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api_test.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl b/third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl

index 3bcfc3e687d4d6c327991a91795d6fdcf920b4b1..48b8c0f91027f27eff2b36e18b6691978e7e426f 100644

--- a/third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl

@@ -28,12 +28,15 @@ DEFINE_TRACE({{class_name.upper_camel_case}}) {

// TODO(dglazkov): Implement attribute getter/setter generation

{% for attribute in attributes %}

-// {{attribute.return_type}} {{attribute.name}}

+// {{attribute.type}} {{attribute.name}}

{% endfor %}

// TODO(dglazkov): Implement method generation

{% for method in methods %}

-// {{method.return_type}} {{class_name.upper_camel_case}}::{{method.name}}

+// {{method.type}} {{class_name.upper_camel_case}}::{{method.name}}

+{% for argument in method.arguments %}

+// {{argument.type}} {{argument.name}}

+{% endfor %}

{% endfor %}

{{class_name.upper_camel_case}}::{{class_name.upper_camel_case}}(blink::{{class_name.upper_camel_case}}* {{class_name.snake_case}})