Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2586)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret. (Closed)
Patch Set: Just fixed a typo in a comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index e3ea8995b0e467c49506715807d8219ed1248013..5822f6d8e570b983795dfc39b5c82f4e5b8c52cb 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1294,7 +1294,22 @@ void RenderViewImpl::OnSelectWordAroundCaret() {
return;
input_handler_->set_handling_input_event(true);
+#if defined(OS_ANDROID)
aelias_OOO_until_Jul13 2017/02/22 03:36:01 I'd prefer it not be OS_ANDROID. This makes compi
Donn Denman 2017/02/22 23:13:01 Done.
+ int start_adjust = 0;
+ int end_adjust = 0;
+ blink::WebRange initial_range = webview()->focusedFrame()->selectionRange();
+ bool did_select = webview()->focusedFrame()->selectWordAroundCaret();
aelias_OOO_until_Jul13 2017/02/22 03:36:00 I'm missing a bit of context; why do we set a care
Donn Denman 2017/02/22 23:13:02 Sorry about the lack of context. When the user ta
+ if (did_select) {
+ blink::WebRange adjusted_range =
+ webview()->focusedFrame()->selectionRange();
+ start_adjust = adjusted_range.startOffset() - initial_range.startOffset();
+ end_adjust = adjusted_range.endOffset() - initial_range.endOffset();
+ }
+ Send(new ViewHostMsg_SelectWordAroundCaret_ACK(GetRoutingID(), did_select,
+ start_adjust, end_adjust));
+#else
webview()->focusedFrame()->selectWordAroundCaret();
+#endif
input_handler_->set_handling_input_event(false);
}

Powered by Google App Engine
This is Rietveld 408576698