content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java - Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java

Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret. (Closed)

Patch Set: Reworked the core code to always return an ACK and check for a null frame. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java ('k') | content/renderer/render_view_impl.cc » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java b/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java

index ea790c29ed90098bf46251af9b20f96316e25a3f..95b2803ae2629547cb049b40b14fdb2386852bb8 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java

@@ -97,6 +97,9 @@ public class SmartSelectionClient implements SelectionClient {

mProvider.cancelAllRequests();

}

+ @Override

+ public void selectWordAroundCaretAck(boolean didSelect, int startAdjust, int endAdjust) {}

private void requestSurroundingText(@RequestType int callbackData) {

if (mNativeSmartSelectionClient == 0) {

onSurroundingTextReceived(callbackData, "", 0, 0);