Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2703643004: [TTS] Add an ACK message to SelectWordAroundCaret. (Closed)
Patch Set: Reworked the core code to always return an ACK and check for a null frame. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.annotation.TargetApi; 7 import android.annotation.TargetApi;
8 import android.app.Activity; 8 import android.app.Activity;
9 import android.app.SearchManager; 9 import android.app.SearchManager;
10 import android.content.ClipData; 10 import android.content.ClipData;
(...skipping 1045 matching lines...) Expand 10 before | Expand all | Expand 10 after
1056 assert !mPendingShowActionMode; 1056 assert !mPendingShowActionMode;
1057 assert !mHidden; 1057 assert !mHidden;
1058 } 1058 }
1059 1059
1060 void onShowUnhandledTapUIIfNeeded(int x, int y) { 1060 void onShowUnhandledTapUIIfNeeded(int x, int y) {
1061 if (mSelectionClient != null) { 1061 if (mSelectionClient != null) {
1062 mSelectionClient.showUnhandledTapUIIfNeeded(x, y); 1062 mSelectionClient.showUnhandledTapUIIfNeeded(x, y);
1063 } 1063 }
1064 } 1064 }
1065 1065
1066 void onSelectWordAroundCaretAck(boolean didSelect, int startAdjust, int endA djust) {
1067 if (mSelectionClient != null) {
1068 mSelectionClient.selectWordAroundCaretAck(didSelect, startAdjust, en dAdjust);
1069 }
1070 }
1071
1066 void destroyActionModeAndUnselect() { 1072 void destroyActionModeAndUnselect() {
1067 mUnselectAllOnDismiss = true; 1073 mUnselectAllOnDismiss = true;
1068 finishActionMode(); 1074 finishActionMode();
1069 } 1075 }
1070 1076
1071 void destroyActionModeAndKeepSelection() { 1077 void destroyActionModeAndKeepSelection() {
1072 mUnselectAllOnDismiss = false; 1078 mUnselectAllOnDismiss = false;
1073 finishActionMode(); 1079 finishActionMode();
1074 } 1080 }
1075 1081
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
1146 if (mPendingShowActionMode) return; 1152 if (mPendingShowActionMode) return;
1147 } 1153 }
1148 1154
1149 // Rely on this method to clear |mHidden| and unhide the action mode . 1155 // Rely on this method to clear |mHidden| and unhide the action mode .
1150 showActionModeOrClearOnFailure(); 1156 showActionModeOrClearOnFailure();
1151 } 1157 }
1152 }; 1158 };
1153 1159
1154 private native void nativeInit(WebContents webContents); 1160 private native void nativeInit(WebContents webContents);
1155 } 1161 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698