[TTS] Add an ACK message to SelectWordAroundCaret.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 
@@ skipping 1260 matching lines @@
     // platform specific ones at the end.
 
     // Have the super handle all other messages.
     IPC_MESSAGE_UNHANDLED(handled = RenderWidget::OnMessageReceived(message))
   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
 void RenderViewImpl::OnSelectWordAroundCaret() {
   if (!webview())

[Donn Denman, 2017/05/11 23:05:46]

I noticed this early return, and think it violates the spirit of having an ACK,
so I reworked this too.  PTAL.

     return;
 
   input_handler_->set_handling_input_event(true);
-  webview()->FocusedFrame()->SelectWordAroundCaret();
+  int start_adjust = 0;
+  int end_adjust = 0;
+  blink::WebRange initial_range = webview()->FocusedFrame()->SelectionRange();

[nasko, 2017/05/11 22:21:38]

FocusedFrame() can return nullptr, it needs to be checked.

[Donn Denman, 2017/05/11 23:05:46]

Done.

+  bool did_select = webview()->FocusedFrame()->SelectWordAroundCaret();
+  if (did_select) {
+    blink::WebRange adjusted_range =
+        webview()->FocusedFrame()->SelectionRange();

[nasko, 2017/05/11 22:21:38]

This is the third call to webview()->FocusedFrame(). I don't think it can change
within the scope of this method, so why not store it in a local variable?

[Donn Denman, 2017/05/11 23:05:46]

Done.

+    start_adjust = adjusted_range.StartOffset() - initial_range.StartOffset();
+    end_adjust = adjusted_range.EndOffset() - initial_range.EndOffset();
+  }
+  Send(new ViewHostMsg_SelectWordAroundCaretAck(GetRoutingID(), did_select,
+                                                start_adjust, end_adjust));
   input_handler_->set_handling_input_event(false);
 }
 
 void RenderViewImpl::OnUpdateTargetURLAck() {
   // Check if there is a targeturl waiting to be sent.
   if (target_url_status_ == TARGET_PENDING)
     Send(new ViewHostMsg_UpdateTargetURL(GetRoutingID(), pending_target_url_));
 
   target_url_status_ = TARGET_NONE;
 }
@@ skipping 1373 matching lines @@
                         input_event.GetCoalescedEventsPointers(), latency_info,
                         dispatch_type);
     return INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
   }
   idle_user_detector_->ActivityDetected();
   return RenderWidget::HandleInputEvent(input_event, latency_info,
                                         dispatch_type);
 }
 
 }  // namespace content