Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: third_party/WebKit/Source/platform/wtf/BUILD.gn

Issue 2703633003: Add initial BUILD.gn in platform/wtf/, and move first a few files there. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/wtf/CryptographicallyRandomNumber.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/wtf/BUILD.gn
diff --git a/third_party/WebKit/Source/platform/wtf/BUILD.gn b/third_party/WebKit/Source/platform/wtf/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..9d4c88f3ea2540367d12bd3b808568e70d26fa56
--- /dev/null
+++ b/third_party/WebKit/Source/platform/wtf/BUILD.gn
@@ -0,0 +1,125 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# The below is a temporary setup during the WTF migration project:
+# https://groups.google.com/a/chromium.org/d/msg/blink-dev/tLdAZCTlcAA/bYXVT8gYCAAJ
+#
+# We are moving wtf/ files to platform/wtf/ incrementally, thus, conceptually,
+# the "wtf" target in wtf/BUILD.gn is being split into two, in a way that
+# only wtf/ can refer the contents in platform/wtf/.
+#
+# To achieve this, we introduce a new target "platform_wtf" here, and configure
+# it so the source files are compiled in the same way as the original "wtf"
+# target. "platform_wtf" can only be used from "wtf" for the moment to allow
+# only redirection headers in wtf/ to include the headers in "platform/wtf".
haraken 2017/02/17 10:37:24 But it's fine to use platform_wtf from core/, modu
Yuta Kitamura 2017/02/17 11:41:05 Yeah, I think you are right. Both gn-wise and DEPS
+#
+# The following configurations are mostly copied from wtf/BUILD.gn, so we
+# can build the source files in the same way.
+#
+# When we finish moving all the files, "platform_wtf" target will take over
+# the role of "wtf".
+#
+# TODO(yutak): Set up platform_wtf_unittests in the similar manner.
+
+assert(!is_ios)
+
+import("//third_party/WebKit/Source/config.gni")
+
+visibility = [ "//third_party/WebKit/Source/wtf/*" ]
+
+config("wtf_config") {
+ if (is_win) {
+ defines = [
+ "__STD_C",
+ "_CRT_SECURE_NO_DEPRECATE",
+ "_SCL_SECURE_NO_DEPRECATE",
+ ]
+ include_dirs = [ "os-win32" ]
+
+ cflags = [
+ # Don't complain about calling specific versions of templatized
+ # functions (e.g. in RefPtrHashMap.h).
+ "/wd4344",
+
+ # dtoa, icu, etc. like doing assignment within conditional.
+ "/wd4706",
+ ]
+
+ if (is_component_build) {
+ # Chromium windows multi-dll build enables C++ exceptions and this causes
+ # wtf to generate 4291 warning due to operator new/delete
+ # implementations. Disable the warning for chromium windows multi-dll
+ # build.
+ cflags += [ "/wd4291" ]
+ }
+ }
+}
+
+component("platform_wtf") {
+ sources = [
+ "CryptographicallyRandomNumber.cpp",
+ "CryptographicallyRandomNumber.h",
+ "WTFExport.h",
+ ]
+
+ configs += [
+ "//third_party/WebKit/Source:config",
+ "//third_party/WebKit/Source:non_test_config",
+ "//third_party/WebKit/Source:blink_pch",
+ ]
+
+ defines = [ "WTF_IMPLEMENTATION=1" ]
+
+ public_configs = [
+ ":wtf_config",
+
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ "//build/config/compiler:no_size_t_to_int_warning",
+ "//third_party/WebKit/Source:features",
+ ]
+
+ public_deps = [
+ "//base",
+ "//third_party/icu",
+ ]
+
+ # Rules changing the |sources| list are temporarily commented out, until
+ # those files are actually moved to here.
+
+ if (is_win) {
+ # sources -= [ "ThreadingPthreads.cpp" ]
+
+ cflags = [ "/wd4068" ] # Unknown pragma.
+ } else {
+ # Non-Windows.
+ # sources -= [
+ # "ThreadSpecificWin.cpp",
+ # "ThreadingWin.cpp",
+ # ]
+ }
+
+ if (is_android) {
+ libs = [ "log" ]
+ }
+ if (is_linux) {
+ libs = [ "dl" ]
+ }
+
+ if (is_mac) {
+ libs = [
+ "CoreFoundation.framework",
+ "Foundation.framework",
+ ]
+ } else {
+ # sources -= [
+ # "text/AtomicStringCF.cpp",
+ # "text/StringImplCF.cpp",
+ # ]
+ }
+
+ if (remove_webcore_debug_symbols) {
+ configs -= [ "//build/config/compiler:default_symbols" ]
+ configs += [ "//build/config/compiler:no_symbols" ]
+ }
+}
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/wtf/CryptographicallyRandomNumber.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698