Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1975)

Issue 270363005: Revert of Statically initialize those zero-size singletons. (Closed)

Created:
6 years, 7 months ago by mtklein
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Statically initialize those zero-size singletons. (https://codereview.chromium.org/270353003/) Reason for revert: breaks windows bots Original issue's description: > Statically initialize those zero-size singletons. > > This way GCC/Clang don't generate the magic static code to call the > pointless T::T() once in a threadsafe way. = {} is plenty initialized. > > BUG=skia:2378 > > Committed: http://code.google.com/p/skia/source/detail?r=14623 TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/record/SkRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M src/record/SkRecords.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Statically initialize those zero-size singletons.
6 years, 7 months ago (2014-05-07 19:32:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/270363005/1
6 years, 7 months ago (2014-05-07 19:33:36 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 19:33:52 UTC) #3
Message was sent while issue was closed.
Change committed as 14625

Powered by Google App Engine
This is Rietveld 408576698