Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: net/BUILD.gn

Issue 270363003: Reduce footprint of registry controlled domain table (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: GN fixed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/registry_controlled_domains/effective_tld_names_unittest1.cc » ('j') | net/net.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index a6760e4fc5da665697d46f3f1c1fc544e492c72c..557b1b53bffd711b32fcc2ae3c14103b5fc91211 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -62,6 +62,33 @@ config("net_win_size_truncation") {
}
}
+config("net_derived_includes") {
+ include_dirs = [ "${root_gen_dir}/net" ]
brettw 2014/05/07 19:50:11 If possible, can you remove this (see comment on G
+}
+
+action_foreach("net_derived_sources") {
+ hard_dep = true
brettw 2014/05/07 19:50:11 Remove this line, it doesn't do anything any more
+
+ script = "tools/tld_cleanup/make_dafsa.py"
+ sources = [
+ "base/registry_controlled_domains/effective_tld_names.gperf",
+ "base/registry_controlled_domains/effective_tld_names_unittest1.gperf",
+ "base/registry_controlled_domains/effective_tld_names_unittest2.gperf",
+ "base/registry_controlled_domains/effective_tld_names_unittest3.gperf",
+ "base/registry_controlled_domains/effective_tld_names_unittest4.gperf",
+ "base/registry_controlled_domains/effective_tld_names_unittest5.gperf",
+ "base/registry_controlled_domains/effective_tld_names_unittest6.gperf",
+ ]
+ outputs = [
+ "${root_gen_dir}/net/{{source_name_part}}-inc.cc"
brettw 2014/05/07 19:50:11 Can you put a TODO here about moving these to the
Ryan Sleevi 2014/05/07 22:54:24 I don't think target_gen_dir is the right thing, s
+ ]
+ args = [
+ "{{source}}",
+ rebase_path("${root_gen_dir}/net/{{source_name_part}}-inc.cc", root_build_dir)
+ ]
+ direct_dependent_configs = [ ":net_derived_includes" ]
+}
+
component("net") {
sources =
gypi_values.net_nacl_common_sources +
@@ -82,6 +109,7 @@ component("net") {
include_dirs = []
deps = [
+ ":net_derived_sources",
":net_resources",
"//base",
"//base:i18n",
« no previous file with comments | « no previous file | net/base/registry_controlled_domains/effective_tld_names_unittest1.cc » ('j') | net/net.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698