Reduce footprint of registry controlled domain table

Reduce footprint of registry controlled domain table

The perfect hash table containing all registry controlled domains is
replaced by a compact graph (a dafsa) to reduce binary size and PSS
of the running process. Size of the new structure is about 33kB
compared to 380kB for the perfect hash table.

Patch by Olle Liljenzin <ollel@opera.com>;, originally at
https://codereview.chromium.org/197183002/

BUG=370672
R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270039

[Ryan Sleevi, 2014-05-07 19:17:54]

Brett: Please review the GN changes
ollel: FYI

[brettw, 2014-05-07 19:50:11]

GN LGTM

https://codereview.chromium.org/270363003/diff/20001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/270363003/diff/20001/net/BUILD.gn#newcode66
net/BUILD.gn:66: include_dirs = [ "${root_gen_dir}/net" ]
If possible, can you remove this (see comment on GYP file).

https://codereview.chromium.org/270363003/diff/20001/net/BUILD.gn#newcode70
net/BUILD.gn:70: hard_dep = true
Remove this line, it doesn't do anything any more (it's implicit for actions in
the version I pushed yesterday).

https://codereview.chromium.org/270363003/diff/20001/net/BUILD.gn#newcode83
net/BUILD.gn:83: "${root_gen_dir}/net/{{source_name_part}}-inc.cc"
Can you put a TODO here about moving these to the target_gen_dir when it's no
longer necessary to match the GYP build?

https://codereview.chromium.org/270363003/diff/20001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/270363003/diff/20001/net/net.gyp#newcode96
net/net.gyp:96: '<(SHARED_INTERMEDIATE_DIR)/net',
Can you remove this and have people include the file as "net/foo.cc"? I think
tohe root gen dir is already on the include path search.

[Ryan Sleevi, 2014-05-07 22:54:24]

brettw: Updated the .gn and .gyp files to match your feedback. Please take
another look to make sure you're happy with the changes, since I didn't quite do
what you requested.

https://codereview.chromium.org/270363003/diff/20001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/270363003/diff/20001/net/BUILD.gn#newcode83
net/BUILD.gn:83: "${root_gen_dir}/net/{{source_name_part}}-inc.cc"
On 2014/05/07 19:50:11, brettw wrote:
> Can you put a TODO here about moving these to the target_gen_dir when it's no
> longer necessary to match the GYP build?

I don't think target_gen_dir is the right thing, since these are #include'd by
other targets. That is, I want a stable path independent of the .gn's internal
structure.

https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn#newcode77
net/BUILD.gn:77:
"${root_gen_dir}/net/base/registry_controlled_domains/{{source_name_part}}-inc.cc"
It'd be great to be able to do something like
"${root_gen_dir}/net/{{source_dir}}/{{source_name_part}}-inc.cc"

but that does not appear to be supported.

[brettw, 2014-05-07 23:53:58]

https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn#newcode77
net/BUILD.gn:77:
"${root_gen_dir}/net/base/registry_controlled_domains/{{source_name_part}}-inc.cc"
On 2014/05/07 22:54:25, Ryan Sleevi wrote:
> It'd be great to be able to do something like
> "${root_gen_dir}/net/{{source_dir}}/{{source_name_part}}-inc.cc"
> 
> but that does not appear to be supported.

Ah, here's what you do: Move this action to a new file in
src/net/base/registry_controlled_domains/BUILD.gn. Then replace this line with:
  outputs = [ "$target_gen_dir/{{source_name_part}}-inc.cc" ]
(update the one below as well). Target gen dir is what you're supposed to use
for stuff like this, and it's basically the current build file's path under
out/gen.

[Ryan Sleevi, 2014-05-08 00:09:58]

On 2014/05/07 23:53:58, brettw wrote:
> https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn
> File net/BUILD.gn (right):
> 
> https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn#newcode77
> net/BUILD.gn:77:
>
"${root_gen_dir}/net/base/registry_controlled_domains/{{source_name_part}}-inc.cc"
> On 2014/05/07 22:54:25, Ryan Sleevi wrote:
> > It'd be great to be able to do something like
> > "${root_gen_dir}/net/{{source_dir}}/{{source_name_part}}-inc.cc"
> > 
> > but that does not appear to be supported.
> 
> Ah, here's what you do: Move this action to a new file in
> src/net/base/registry_controlled_domains/BUILD.gn. Then replace this line
with:
>   outputs = [ "$target_gen_dir/{{source_name_part}}-inc.cc" ]
> (update the one below as well). Target gen dir is what you're supposed to use
> for stuff like this, and it's basically the current build file's path under
> out/gen.

Are you happy / can you live with this as is?

It seems like the question of where/how BUILD.gn's live is another discussion,
but if you're OK with living with this for now, we can revisit when it's
clearer.

That is, it's "nice", as a net/OWNER, that all of net/'s targets are
encapsulated in net/BUILD.gn, but it sounds like from your response that the
Brave New GN world is to use BUILD.gn at a variety of source levels, correct?

[brettw, 2014-05-08 19:41:01]

On 2014/05/08 00:09:58, Ryan Sleevi wrote:
> On 2014/05/07 23:53:58, brettw wrote:
> > https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn
> > File net/BUILD.gn (right):
> > 
> > https://codereview.chromium.org/270363003/diff/30001/net/BUILD.gn#newcode77
> > net/BUILD.gn:77:
> >
>
"${root_gen_dir}/net/base/registry_controlled_domains/{{source_name_part}}-inc.cc"
> > On 2014/05/07 22:54:25, Ryan Sleevi wrote:
> > > It'd be great to be able to do something like
> > > "${root_gen_dir}/net/{{source_dir}}/{{source_name_part}}-inc.cc"
> > > 
> > > but that does not appear to be supported.
> > 
> > Ah, here's what you do: Move this action to a new file in
> > src/net/base/registry_controlled_domains/BUILD.gn. Then replace this line
> with:
> >   outputs = [ "$target_gen_dir/{{source_name_part}}-inc.cc" ]
> > (update the one below as well). Target gen dir is what you're supposed to
use
> > for stuff like this, and it's basically the current build file's path under
> > out/gen.
> 
> Are you happy / can you live with this as is?
> 
> It seems like the question of where/how BUILD.gn's live is another discussion,
> but if you're OK with living with this for now, we can revisit when it's
> clearer.
> 
> That is, it's "nice", as a net/OWNER, that all of net/'s targets are
> encapsulated in net/BUILD.gn, but it sounds like from your response that the
> Brave New GN world is to use BUILD.gn at a variety of source levels, correct?

Yes, you can and should have BUILD.gn files anywhere.

If it's not in the right place now, I don't see when we would eve move it, and
moving it should take 5 mins.

[Ryan Sleevi, 2014-05-13 07:01:40]

Committed patchset #5 manually as r270039 (presubmit successful).