Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2703573002: core/loader: move SinkDocument outside core/loader (Closed)

Created:
3 years, 10 months ago by Takashi Toyoshima
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core/loader: move SinkDocument outside core/loader Probably, this should be placed in core/dom today. BUG=none Review-Url: https://codereview.chromium.org/2703573002 Cr-Commit-Position: refs/heads/master@{#451735} Committed: https://chromium.googlesource.com/chromium/src/+/f8e391b45ab3c61a3d061a44c8007cd44efab965

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -111 lines) Patch
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/SinkDocument.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/SinkDocument.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/loader/SinkDocument.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/core/loader/SinkDocument.cpp View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Takashi Toyoshima
WDYT?
3 years, 10 months ago (2017-02-16 11:25:18 UTC) #3
yhirano
I agree that it shouldn't be in core/loader, but I'm not sure where it should ...
3 years, 10 months ago (2017-02-17 03:45:12 UTC) #5
Takashi Toyoshima
dominicc: ping
3 years, 10 months ago (2017-02-20 05:16:55 UTC) #6
Takashi Toyoshima
+hayato as another core/dom specialist
3 years, 10 months ago (2017-02-21 05:08:23 UTC) #8
dominicc (has gone to gerrit)
lgtm I think it's fine to put in core/dom. It's a Document.
3 years, 10 months ago (2017-02-21 06:44:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703573002/20001
3 years, 10 months ago (2017-02-21 06:44:27 UTC) #11
Takashi Toyoshima
Thanks
3 years, 10 months ago (2017-02-21 06:47:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/122914)
3 years, 10 months ago (2017-02-21 09:33:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703573002/20001
3 years, 10 months ago (2017-02-21 11:18:55 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 11:56:05 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8e391b45ab3c61a3d061a44c800...

Powered by Google App Engine
This is Rietveld 408576698