src/parsing/parser-base.h - Issue 2703563002: [ESNext] Implement DynamicImportCall

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser-base.h

Issue 2703563002: [ESNext] Implement DynamicImportCall (Closed)

Patch Set: add test + comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser-base.h

diff --git a/src/parsing/parser-base.h b/src/parsing/parser-base.h

index 51a351ecd9c086bd1e774df64d9d8e471393c537..e88be7f8421d4b6a36fb3114d0faa2dfda983b9d 100644

--- a/src/parsing/parser-base.h

+++ b/src/parsing/parser-base.h

@@ -3350,9 +3350,7 @@ ParserBase<Impl>::ParseDynamicImportExpression(bool* ok) {

Expect(Token::LPAREN, CHECK_OK);

ExpressionT arg = ParseAssignmentExpression(true, CHECK_OK);

Expect(Token::RPAREN, CHECK_OK);

- ZoneList<ExpressionT>* args = new (zone()) ZoneList<ExpressionT>(1, zone());

- args->Add(arg, zone());

- return factory()->NewCallRuntime(Runtime::kDynamicImportCall, args, pos);

+ return factory()->NewImportCallExpression(arg, pos);

}

template <typename Impl>