Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/d8.h

Issue 2703563002: [ESNext] Implement DynamicImportCall (Closed)
Patch Set: simplify error handling Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index 21e4c4f0833c9f26da1b49813c1606d3d06351b5..b212b32bafb48772093a02707bee9bbacc17ccaa 100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -280,7 +280,6 @@ class Worker {
base::Atomic32 running_;
};
-
class ShellOptions {
public:
ShellOptions()
@@ -440,7 +439,11 @@ class Shell : public i::AllStatic {
static void SetUMask(const v8::FunctionCallbackInfo<v8::Value>& args);
static void MakeDirectory(const v8::FunctionCallbackInfo<v8::Value>& args);
static void RemoveDirectory(const v8::FunctionCallbackInfo<v8::Value>& args);
-
+ static void HostImportModuleDynamically(Isolate* isolate,
+ Local<String> source_url,
neis 2017/03/17 10:36:31 Nit: referrer
gsathya 2017/03/17 21:47:59 Done.
+ Local<String> specifier,
+ Local<Promise> promise);
+ static void DoHostImportModuleDynamically(void* data);
neis 2017/03/17 10:36:32 Please add a comment saying what "data" is and why
gsathya 2017/03/17 21:47:59 Done.
static void AddOSMethods(v8::Isolate* isolate,
Local<ObjectTemplate> os_template);

Powered by Google App Engine
This is Rietveld 408576698