Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: src/d8.h

Issue 2703563002: [ESNext] Implement DynamicImportCall (Closed)
Patch Set: fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/typing.cc ('k') | src/d8.cc » ('j') | src/d8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index 21e4c4f0833c9f26da1b49813c1606d3d06351b5..c64e2d5921e3b24f18fc9d1a1caa45663e28d8d9 100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -280,7 +280,6 @@ class Worker {
base::Atomic32 running_;
};
-
class ShellOptions {
public:
ShellOptions()
@@ -440,7 +439,11 @@ class Shell : public i::AllStatic {
static void SetUMask(const v8::FunctionCallbackInfo<v8::Value>& args);
static void MakeDirectory(const v8::FunctionCallbackInfo<v8::Value>& args);
static void RemoveDirectory(const v8::FunctionCallbackInfo<v8::Value>& args);
-
+ static void HostImportModuleDynamically(Isolate* isolate,
+ Local<String> source_url,
+ Local<String> specifier,
+ Local<Promise> promise);
+ static void DoHostImportModuleDynamically(void* data);
static void AddOSMethods(v8::Isolate* isolate,
Local<ObjectTemplate> os_template);
@@ -480,8 +483,9 @@ class Shell : public i::AllStatic {
v8::MaybeLocal<Value> global_object);
static void DisposeRealm(const v8::FunctionCallbackInfo<v8::Value>& args,
int index);
- static MaybeLocal<Module> FetchModuleTree(v8::Local<v8::Context> context,
- const std::string& file_name);
+ static MaybeLocal<Module> FetchModuleTree(
+ v8::Local<v8::Context> context, const std::string& file_name,
+ v8::MaybeLocal<v8::Value>* maybe_exception);
};
« no previous file with comments | « src/crankshaft/typing.cc ('k') | src/d8.cc » ('j') | src/d8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698