[ESNext] Implement DynamicImportCall

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 1053 matching lines @@
    */
   V8_WARN_UNUSED_RESULT bool Instantiate(Local<Context> context,
                                          ResolveCallback callback);
 
   /**
    * ModuleEvaluation
    *
    * Returns the completion value.
    */
   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+
+  static bool FinishDynamicImportSuccess(Local<Context> context,

[adamk, 2017/03/15 21:36:43]

It looks like this returns false if PromiseResolve somehow throws? It should
have V8_WARN_UNUSED_RESULT in that case. Same goes below.

The idea is that the caller will have to do something about the exception.

[gsathya, 2017/03/16 00:59:24]

Done.

+                                         Local<Promise> promise,
+                                         Local<Module> module);
+
+  static bool FinishDynamicImportFailure(Local<Context> context,
+                                         Local<Promise> promise,
+                                         Local<Value> exception);
 };
 
 /**
  * A compiled JavaScript script, tied to a Context which was active when the
  * script was compiled.
  */
 class V8_EXPORT Script {
  public:
   /**
    * A shorthand for ScriptCompiler::Compile().
@@ skipping 4696 matching lines @@
     kAllocationActionAllocate = 1 << 0,
     kAllocationActionFree = 1 << 1,
     kAllocationActionAll = kAllocationActionAllocate | kAllocationActionFree
   };
 
 // --- Enter/Leave Script Callback ---
 typedef void (*BeforeCallEnteredCallback)(Isolate*);
 typedef void (*CallCompletedCallback)(Isolate*);
 typedef void (*DeprecatedCallCompletedCallback)();
 
+typedef void (*HostImportModuleDynamicallyCallback)(Isolate* isolate,
+                                                    Local<String> referrer,
+                                                    Local<String> specifier,
+                                                    Local<Promise> promise);

[adamk, 2017/03/15 21:36:43]

As previously discussed, can you type the Promise differently, so that the
embedder doesn't accidentally resolve it in the wrong way?

+
 /**
  * PromiseHook with type kInit is called when a new promise is
  * created. When a new promise is created as part of the chain in the
  * case of Promise.then or in the intermediate promises created by
  * Promise.{race, all}/AsyncFunctionAwait, we pass the parent promise
  * otherwise we pass undefined.
  *
  * PromiseHook with type kResolve is called at the beginning of
  * resolve or reject function defined by CreateResolvingFunctions.
  *
@@ skipping 529 matching lines @@
   struct CreateParams {
     CreateParams()
         : entry_hook(nullptr),
           code_event_handler(nullptr),
           snapshot_blob(nullptr),
           counter_lookup_callback(nullptr),
           create_histogram_callback(nullptr),
           add_histogram_sample_callback(nullptr),
           array_buffer_allocator(nullptr),
           external_references(nullptr),
-          allow_atomics_wait(true) {}
+          allow_atomics_wait(true),
+          host_import_module_dynamically_callback_(nullptr) {}
 
     /**
      * The optional entry_hook allows the host application to provide the
      * address of a function that's invoked on entry to every V8-generated
      * function.  Note that entry_hook is invoked at the very start of each
      * generated function.
      * An entry_hook can only be provided in no-snapshot builds; in snapshot
      * builds it must be nullptr.
      */
     FunctionEntryHook entry_hook;
@@ skipping 42 matching lines @@
      * deserialization. This array and its content must stay valid for the
      * entire lifetime of the isolate.
      */
     intptr_t* external_references;
 
     /**
      * Whether calling Atomics.wait (a function that may block) is allowed in
      * this isolate.
      */
     bool allow_atomics_wait;
+
+    /**
+     *  TODO(gsathya): Write doc
+     */
+    HostImportModuleDynamicallyCallback
+        host_import_module_dynamically_callback_;
   };
 
 
   /**
    * Stack-allocated class which sets the isolate for all operations
    * executed within a local scope.
    */
   class V8_EXPORT Scope {
    public:
     explicit Scope(Isolate* isolate) : isolate_(isolate) {
@@ skipping 3419 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // INCLUDE_V8_H_