Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2703553003: Create a new class for parser tests that test top level constructs. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a new class for parser tests that test top level constructs. These parser tests should be easy to port over to Fasta; the others will be more difficult because they invoke parser methods that may not have exact analogues in Fasta's parser. This CL is almost entirely code motion; the only substantive changes are the creation of the new class TopLevelParserTest, and the creation of the new mixin ParserTestHelpers (for the helper methods needed by TopLevelParserTest). R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d5f44ff8be73c0c7cfd0f61141b6326a8e734a16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5961 lines, -5944 lines) Patch
M pkg/analyzer/test/generated/parser_test.dart View 6 chunks +5961 lines, -5944 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-16 18:52:31 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-16 18:54:51 UTC) #3
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-16 18:57:41 UTC) #4
Paul Berry
3 years, 10 months ago (2017-02-16 19:31:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5f44ff8be73c0c7cfd0f61141b6326a8e734a16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698