Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 270353002: Removing the enable-usermedia-screen-capture flag from about:flags. (Closed)

Created:
6 years, 7 months ago by jiayl
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing the enable-usermedia-screen-capture flag from about:flags. The command line switch enable-usermedia-screen-capturing will still work. BUG=347641 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jiayl
PTAL
6 years, 7 months ago (2014-05-07 16:46:51 UTC) #1
jiayl
Ping reviewers.
6 years, 7 months ago (2014-05-12 16:00:23 UTC) #2
juberti
lgtm lgtm
6 years, 7 months ago (2014-05-13 05:24:06 UTC) #3
Sergey Ulanov
Lgtm On May 12, 2014 10:00 AM, <jiayl@chromium.org> wrote: > Ping reviewers. > > https://codereview.chromium.org/270353002/ ...
6 years, 7 months ago (2014-05-13 14:38:51 UTC) #4
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 7 months ago (2014-05-13 15:25:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/270353002/1
6 years, 7 months ago (2014-05-13 15:26:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 15:26:54 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-13 15:26:55 UTC) #8
jiayl
Sergey, could you redo your lgtm stamp? Somehow presubmit does not recognize your last one.
6 years, 7 months ago (2014-05-13 15:31:02 UTC) #9
jiayl
Ping Sergey.
6 years, 7 months ago (2014-05-15 00:14:07 UTC) #10
Sergey Ulanov
On 2014/05/15 00:14:07, jiayl wrote: > Ping Sergey. lgtm
6 years, 7 months ago (2014-05-21 01:24:51 UTC) #11
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-21 01:25:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/270353002/1
6 years, 7 months ago (2014-05-21 01:26:35 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 01:40:23 UTC) #14
Message was sent while issue was closed.
Change committed as 272046

Powered by Google App Engine
This is Rietveld 408576698