ninja/mac: Add iOS fields to ExtraPlistItems for ninja builds.

test/ios/gyptest-per-config-settings.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Verifies that device and simulator bundles are built correctly.
 """
 
+import plistlib
 import TestGyp
 import subprocess
 import sys
 
 
 def CheckFileType(file, expected):
   proc = subprocess.Popen(['lipo', '-info', file], stdout=subprocess.PIPE)
   o = proc.communicate()[0].strip()
   assert not proc.returncode
   if not expected in o:
     print 'File: Expected %s, got %s' % (expected, o)
     test.fail_test()
 
 
+def CheckPlistvalue(plist, key, expected):
+  if key not in plist:
+    print '%s not set in plist' % key
+    test.fail_test()
+    return
+  actual = plist[key]
+  if actual != expected:
+    print 'File: Expected %s, got %s for %s' % (expected, actual, key)
+    test.fail_test()
+
+
 if sys.platform == 'darwin':
   # TODO(justincohen): Enable this in xcode too once ninja can codesign and bots
   # are configured with signing certs.
   test = TestGyp.TestGyp(formats=['ninja'])
 
   test.run_gyp('test-device.gyp', chdir='app-bundle')
 
   for configuration in ['Default-iphoneos', 'Default']:
     test.set_configuration(configuration)
     test.build('test-device.gyp', test.ALL, chdir='app-bundle')
     result_file = test.built_file_path('Test App Gyp.bundle/Test App Gyp',
                                        chdir='app-bundle')
     test.must_exist(result_file)
+
+    info_plist = test.built_file_path('Test App Gyp.bundle/Info.plist',
+                                      chdir='app-bundle')
+    plist = plistlib.readPlist(info_plist)

[Nico, 2013/10/11 20:20:49]

Is it possible to put this in a test that runs under xcode too? This seems like
something that'd be valuable to compare to the xcode behavior.

[justincohen, 2013/10/12 14:52:28]

Done, although I had to disable device builds for the bots.  simulator xcode
builds should be OK.

On 2013/10/11 20:20:49, Nico wrote:

+
+    CheckPlistvalue(plist, 'UIDeviceFamily', [1, 2])
+
     if configuration == 'Default-iphoneos':
       CheckFileType(result_file, 'armv7')
+      CheckPlistvalue(plist, 'CFBundleSupportedPlatforms', ['iPhoneOS'])
     else:
       CheckFileType(result_file, 'i386')
+      CheckPlistvalue(plist, 'CFBundleSupportedPlatforms', ['iPhoneSimulator'])
 
   test.pass_test()