Issue 27035003: ninja/mac: Add iOS fields to ExtraPlistItems for ninja builds.

Issue 27035003: ninja/mac: Add iOS fields to ExtraPlistItems for ninja builds. (Closed)

Created:
7 years, 2 months ago by Justin Cohen (wrong one)

Modified:
7 years, 2 months ago

Reviewers:
Nico, justincohen

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

ninja/mac: Add iOS fields to ExtraPlistItems for ninja builds. Add CFBundleSupportedPlatforms and UIDeviceFamily for ninja builds. Required changing ExtraPlistItems from list of strings to json.

Patch Set 8 : cleanup #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -9 lines)			Patch
M	pylib/gyp/generator/ninja.py	View	1 2 3 4 5 6	2 chunks	+2 lines, -1 line	0 comments	Download
M	pylib/gyp/mac_tool.py	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -1 line	0 comments	Download
M	pylib/gyp/xcode_emulation.py	View	1 2 3 4 5 6	2 chunks	+14 lines, -3 lines	0 comments	Download
M	test/ios/app-bundle/test-device.gyp	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	1 comment	Download
M	test/ios/gyptest-per-config-settings.py	View	1 2 3 4 5 6	2 chunks	+36 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/27035003/diff/23001/pylib/gyp/xcode_emulation.py File pylib/gyp/xcode_emulation.py (right): https://codereview.chromium.org/27035003/diff/23001/pylib/gyp/xcode_emulation.py#newcode796 pylib/gyp/xcode_emulation.py:796: family = self.xcode_settings[configname].get('TARGETED_DEVICE_FAMILY') return self.xcode_settings[configname].get('TARGETED_DEVICE_FAMILY', '1').split(',') https://codereview.chromium.org/27035003/diff/23001/test/ios/gyptest-per-config-settings.py File test/ios/gyptest-per-config-settings.py ...

7 years, 2 months ago (2013-10-11 20:20:49 UTC) #4

justincohen

Done, with some limitations. PTAL! https://codereview.chromium.org/27035003/diff/23001/pylib/gyp/xcode_emulation.py File pylib/gyp/xcode_emulation.py (right): https://codereview.chromium.org/27035003/diff/23001/pylib/gyp/xcode_emulation.py#newcode796 pylib/gyp/xcode_emulation.py:796: family = self.xcode_settings[configname].get('TARGETED_DEVICE_FAMILY') Almost, ...

7 years, 2 months ago (2013-10-12 14:52:27 UTC) #5

Nico

lgtm! https://codereview.chromium.org/27035003/diff/39001/test/ios/app-bundle/test-device.gyp File test/ios/app-bundle/test-device.gyp (right): https://codereview.chromium.org/27035003/diff/39001/test/ios/app-bundle/test-device.gyp#newcode33 test/ios/app-bundle/test-device.gyp:33: 'TARGETED_DEVICE_FAMILY': '1,2', Having another target without TARGETED_DEVICE_FAMILY (to ...

7 years, 2 months ago (2013-10-13 02:00:29 UTC) #6

Nico

7 years, 2 months ago (2013-10-13 02:00:40 UTC) #7

On 2013/10/13 02:00:29, Nico wrote:
> lgtm!
> 
>
https://codereview.chromium.org/27035003/diff/39001/test/ios/app-bundle/test-...
> File test/ios/app-bundle/test-device.gyp (right):
> 
>
https://codereview.chromium.org/27035003/diff/39001/test/ios/app-bundle/test-...
> test/ios/app-bundle/test-device.gyp:33: 'TARGETED_DEVICE_FAMILY': '1,2',
> Having another target without TARGETED_DEVICE_FAMILY (to test the default)
would
> be good too.

(could be in a separate cl)

Expand Messages | Collapse Messages