Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/android/contextualsearch/contextual_search_context.h

Issue 2703473002: [TTS] Extract tapped text before showing UI. (Closed)
Patch Set: Moved handleHideContextualSearch into hideContextualSearchUI, and updated comments in response to T… Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/contextualsearch/contextual_search_context.h
diff --git a/chrome/browser/android/contextualsearch/contextual_search_context.h b/chrome/browser/android/contextualsearch/contextual_search_context.h
index ba4ebbf3a4d20ed229928078d2e58bf7cba949c9..3226a97d1a1f95a6d5b2ae90729b0fff840295d5 100644
--- a/chrome/browser/android/contextualsearch/contextual_search_context.h
+++ b/chrome/browser/android/contextualsearch/contextual_search_context.h
@@ -18,8 +18,7 @@ struct ContextualSearchContext {
public:
ContextualSearchContext(JNIEnv* env, jobject obj);
// Constructor for tests.
- ContextualSearchContext(const std::string& selected_text,
- const std::string& home_country,
+ ContextualSearchContext(const std::string& home_country,
const GURL& page_url,
const std::string& encoding);
~ContextualSearchContext();
@@ -44,10 +43,15 @@ struct ContextualSearchContext {
void SetResolveProperties(
JNIEnv* env,
jobject obj,
- const base::android::JavaParamRef<jstring>& j_selection,
const base::android::JavaParamRef<jstring>& j_home_country,
jboolean j_may_send_base_page_url);
+ // Adjust the current selection offsets by the given signed amounts.
+ void AdjustSelection(JNIEnv* env,
+ jobject obj,
+ jint j_start_adjust,
+ jint j_end_adjust);
+
// Gets the URL of the base page.
const GURL GetBasePageUrl() const;
// Sets the URL of the base page.
@@ -67,9 +71,6 @@ struct ContextualSearchContext {
int end_offset,
const base::string16& surrounding_text);
- // Gets the original selection.
- const std::string GetOriginalSelectedText() const;
-
// Gets the text surrounding the selection (including the selection).
const base::string16 GetSurroundingText() const;
@@ -87,7 +88,6 @@ struct ContextualSearchContext {
bool can_resolve;
bool can_send_base_page_url;
- std::string selected_text;
std::string home_country;
GURL base_page_url;
std::string base_page_encoding;

Powered by Google App Engine
This is Rietveld 408576698