Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3465)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java

Issue 2703473002: [TTS] Extract tapped text before showing UI. (Closed)
Patch Set: Moved handleHideContextualSearch into hideContextualSearchUI, and updated comments in response to T… Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java
index 40892f4e09cee2e2f09562f905b67cfa5e54f63e..865f36a0b2390b8fa4a2aaaa40d8a0f5ede54acc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionHandler.java
@@ -18,6 +18,11 @@ interface ContextualSearchSelectionHandler {
public void handleScroll();
/**
+ * Handle the selection being cleared on the base page.
+ */
+ public void handleSelectionCleared();
+
+ /**
* Handle a valid tap gesture on the base page.
*/
public void handleValidTap();
@@ -61,6 +66,11 @@ interface ContextualSearchSelectionHandler {
public void handleSuppressedTap();
/**
+ * Handle a Tap gesture that has not been suppressed by showing the Tap Search UI.
+ */
+ public void handleNonSuppressedTap();
+
+ /**
* Handle updating metrics to reflect that a Tap gesture <i>would</i> be suppressed
* for the given heuristics.
* @param tapHeuristics The set of heuristics that would suppress the Tap.

Powered by Google App Engine
This is Rietveld 408576698