Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateControllerWrapper.java

Issue 2703473002: [TTS] Extract tapped text before showing UI. (Closed)
Patch Set: Added some tests, fixed some tests, added DCHECKS to native context, rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateControllerWrapper.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateControllerWrapper.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateControllerWrapper.java
new file mode 100644
index 0000000000000000000000000000000000000000..53e219816c4480fd2fff16c3544216443225c03d
--- /dev/null
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateControllerWrapper.java
@@ -0,0 +1,57 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.contextualsearch;
+
+import org.chromium.base.CollectionUtil;
+
+import java.util.ArrayList;
+import java.util.List;
+
+class ContextualSearchInternalStateControllerWrapper
Theresa 2017/04/26 18:01:15 nit: JavaDoc?
Donn Denman 2017/04/26 20:28:17 Done for the class, constructor, and public method
+ extends ContextualSearchInternalStateController {
+ static final List<InternalState> EXPECTED_TAP_RESOLVE_SEQUENCE =
+ CollectionUtil.newArrayList(InternalState.SELECTION_CLEARED_RECOGNIZED,
+ InternalState.TAP_RECOGNIZED, InternalState.GATHERING_SURROUNDINGS,
+ InternalState.DECIDING_SUPPRESSION, InternalState.START_SHOWING_TAP_UI,
+ InternalState.SHOW_FULL_TAP_UI, InternalState.RESOLVING);
+ static final List<InternalState> EXPECTED_LONGPRESS_SEQUENCE =
+ CollectionUtil.newArrayList(InternalState.LONG_PRESS_RECOGNIZED,
+ InternalState.GATHERING_SURROUNDINGS, InternalState.SHOWING_LONGPRESS_SEARCH);
+
+ private List<InternalState> mStartedStates = new ArrayList<InternalState>();
+ private List<InternalState> mFinishedStates = new ArrayList<InternalState>();
+
+ ContextualSearchInternalStateControllerWrapper(
Donn Denman 2017/04/26 20:28:17 Also realized this constructor is only called from
+ ContextualSearchPolicy policy, ContextualSearchInternalStateHandler handler) {
+ super(policy, handler);
+ }
+
+ @Override
+ void notifyStartingWorkOn(InternalState state) {
+ mStartedStates.add(state);
+ super.notifyStartingWorkOn(state);
+ }
+
+ @Override
+ void notifyFinishedWorkOn(InternalState state) {
+ mFinishedStates.add(state);
+ super.notifyFinishedWorkOn(state);
+ }
+
+ List<InternalState> getStartedStates() {
+ return mStartedStates;
+ }
+
+ List<InternalState> getFinishedStates() {
+ return mFinishedStates;
+ }
+
+ static ContextualSearchInternalStateControllerWrapper makeNewInternalStateControllerWrapper(
+ ContextualSearchManager manager) {
+ return new ContextualSearchInternalStateControllerWrapper(
+ manager.getContextualSearchPolicy(),
+ manager.getContextualSearchInternalStateHandler());
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698