chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2703473002: [TTS] Extract tapped text before showing UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2703473002: [TTS] Extract tapped text before showing UI. (Closed)

Patch Set: Added some tests, fixed some tests, added DCHECKS to native context, rebased. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateHandler.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index ca0009bde040ea58b8c747c3170dee6c658669db..80daf26d2d6e0ba52be44392d816a73a68d67796 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -748,7 +748,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

mCompositorViewHolder.onNativeLibraryReady(getWindowAndroid(), getTabContentManager());

if (isContextualSearchAllowed() && ContextualSearchFieldTrial.isEnabled()) {

- mContextualSearchManager = new ContextualSearchManager(this, getWindowAndroid(), this);

+ mContextualSearchManager = new ContextualSearchManager(this, this);

}

if (ReaderModeManager.isEnabled(this)) {