Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3976)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java

Issue 2703463002: [List UI Unification] Basic list unification for phones (Closed)
Patch Set: [List UI Unification] Basic list unification for phones Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
index ca5f2c22ed16620fd0d9b2bf08d25fa8ebbc23ce..24f1eaaa65c64c20e52754791bcade9503173804 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
@@ -22,6 +22,7 @@ import org.chromium.chrome.browser.widget.TintedImageButton;
import org.chromium.chrome.browser.widget.TintedImageView;
import org.chromium.chrome.browser.widget.selection.SelectableItemView;
import org.chromium.ui.UiUtils;
+import org.chromium.ui.base.DeviceFormFactor;
/**
* The view for a downloaded item displayed in the Downloads list.
@@ -105,6 +106,10 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
mItem.cancel();
}
});
+
+ if (!DeviceFormFactor.isLargeTablet(getContext())) {
+ setLateralMarginsForDefaultDisplay(mLayoutContainer);
+ }
}
@Override
@@ -194,6 +199,9 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
(MarginLayoutParams) mDownloadPercentageView.getLayoutParams(), mMargin);
}
}
+
+ setBackgroundResourceForGroupPosition(
+ getItem().isFirstInGroup(), getItem().isLastInGroup());
}
/**
@@ -224,6 +232,13 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
updateIconView();
}
+ @Override
+ public void setBackgroundResourceForGroupPosition(
+ boolean isFirstInGroup, boolean isLastInGroup) {
+ if (DeviceFormFactor.isLargeTablet(getContext())) return;
+ super.setBackgroundResourceForGroupPosition(isFirstInGroup, isLastInGroup);
+ }
+
private void updateIconView() {
if (isChecked()) {
mIconView.setBackgroundColor(mIconBackgroundColorSelected);

Powered by Google App Engine
This is Rietveld 408576698