[List UI Unification] Basic list unification for phones

chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
index 6f72fff3944bdc50e8db2beccd8ce76a6ace41e1..df001b6332a63f4e4579ac80beb48e28de4c5ede 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
@@ -20,6 +20,7 @@ import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
 import org.chromium.chrome.browser.widget.TintedImageButton;
 import org.chromium.chrome.browser.widget.selection.SelectableItemView;
 import org.chromium.components.bookmarks.BookmarkId;
+import org.chromium.ui.base.DeviceFormFactor;
 
 import java.util.List;
 
@@ -186,6 +187,10 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo
                 }
             });
         }
+
+        if (isSelectable() && !DeviceFormFactor.isLargeTablet(getContext())) {

[gone, 2017/02/17 01:45:02]

Is this only called for two out of the three possible layouts?  It seems like
something that should be explicitly called by super.onFinishInflate().  Granted,
they look ever so slightly different :/

[Theresa, 2017/02/17 17:34:28]

I added some comments. This is temporary, until bookmarks and downloads are
width constrained to 600dp and use the list item backgrounds on tablets. Once
that happens, we'll use a MarginResizer here similar to history. For now, the
lateral margins need to be set to hide the shadows.

+            setLateralMarginsForDefaultDisplay(findViewById(R.id.bookmark_row));
+        }
     }
 
     @Override
@@ -252,4 +257,10 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo
     public void onFolderStateSet(BookmarkId folder) {
     }
 
+    @Override
+    public void setBackgroundResourceForGroupPosition(
+            boolean isFirstInGroup, boolean isLastInGroup) {
+        if (DeviceFormFactor.isLargeTablet(getContext()) || !isSelectable()) return;

[gone, 2017/02/17 01:45:02]

Leave a comment here about why it's not doing anything?  Do you have to worry
about the View being rebound for something else that is suddenly not selectable?

[Theresa, 2017/02/17 17:34:28]

I added comments in other places and extracted this check into a variable that
makes it more obvious what we're checking for.
No. BookmarkSearchRow, a subclass of BookmarkRow, is not selectable. Since
isSelectable() is a property of the item view rather than the item, there's no
possibility of rebinding causing isSelectable() to change.


I do, however, have to worry about updating the background drawable if items are
removed.

+        super.setBackgroundResourceForGroupPosition(isFirstInGroup, isLastInGroup);
+    }
 }