[List UI Unification] Basic list unification for phones

chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.bookmarks;
 
 import android.content.Context;
 import android.util.AttributeSet;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.AdapterView;
 import android.widget.AdapterView.OnItemClickListener;
 import android.widget.ArrayAdapter;
 import android.widget.ImageView;
 import android.widget.ListPopupWindow;
 import android.widget.TextView;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
 import org.chromium.chrome.browser.widget.TintedImageButton;
 import org.chromium.chrome.browser.widget.selection.SelectableItemView;
 import org.chromium.components.bookmarks.BookmarkId;
+import org.chromium.ui.base.DeviceFormFactor;
 
 import java.util.List;
 
 /**
  * Common logic for bookmark and folder rows.
  */
 abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements BookmarkUIObserver {
 
     protected ImageView mIconImageView;
     protected TextView mTitleView;
     protected TintedImageButton mMoreIcon;
 
     protected BookmarkDelegate mDelegate;
     protected BookmarkId mBookmarkId;
     private ListPopupWindow mPopupMenu;
     private boolean mIsAttachedToWindow;
+    private boolean mShouldUseListItemBackground;
 
     /**
      * Constructor for inflating from XML.
      */
     public BookmarkRow(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
 
     /**
      * Updates this row for the given {@link BookmarkId}.
@@ skipping 130 matching lines @@
         if (isSelectable()) {
             mMoreIcon = (TintedImageButton) findViewById(R.id.more);
             mMoreIcon.setVisibility(VISIBLE);
             mMoreIcon.setOnClickListener(new OnClickListener() {
                 @Override
                 public void onClick(View view) {
                     showMenu(view);
                 }
             });
         }
+
+        // TODO(twellington): remove this after the bookmarks 720dp layout is restyled
+        //                    to match the < 720dp style and BookmarkSearchView is refactored.
+        //                    Currently BookmarkSearchRow extends BookmarkRow but is not selectable.
+        mShouldUseListItemBackground =
+                isSelectable() && !DeviceFormFactor.isLargeTablet(getContext());
+
+        // TODO(twellington): Replace this with a MarginResizer after the bookmarks layout is width
+        //                    constrained to 600dp.
+        if (mShouldUseListItemBackground) {
+            setLateralMarginsForDefaultDisplay(findViewById(R.id.bookmark_row));
+        }
     }
 
     @Override
     protected void onAttachedToWindow() {
         super.onAttachedToWindow();
         mIsAttachedToWindow = true;
         if (mDelegate != null) {
             initialize();
         }
     }
@@ skipping 46 matching lines @@
 
     @Override
     public void onDestroy() {
         cleanup();
     }
 
     @Override
     public void onFolderStateSet(BookmarkId folder) {
     }
 
+    @Override
+    public void setBackgroundResourceForGroupPosition(
+            boolean isFirstInGroup, boolean isLastInGroup) {
+        if (!mShouldUseListItemBackground) return;
+        super.setBackgroundResourceForGroupPosition(isFirstInGroup, isLastInGroup);
+    }
 }