OLD | NEW |
---|---|
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 package org.chromium.chrome.browser.bookmarks; | 5 package org.chromium.chrome.browser.bookmarks; |
6 | 6 |
7 import android.content.Context; | 7 import android.content.Context; |
8 import android.util.AttributeSet; | 8 import android.util.AttributeSet; |
9 import android.view.View; | 9 import android.view.View; |
10 import android.view.ViewGroup; | 10 import android.view.ViewGroup; |
11 import android.widget.AdapterView; | 11 import android.widget.AdapterView; |
12 import android.widget.AdapterView.OnItemClickListener; | 12 import android.widget.AdapterView.OnItemClickListener; |
13 import android.widget.ArrayAdapter; | 13 import android.widget.ArrayAdapter; |
14 import android.widget.ImageView; | 14 import android.widget.ImageView; |
15 import android.widget.ListPopupWindow; | 15 import android.widget.ListPopupWindow; |
16 import android.widget.TextView; | 16 import android.widget.TextView; |
17 | 17 |
18 import org.chromium.chrome.R; | 18 import org.chromium.chrome.R; |
19 import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem; | 19 import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem; |
20 import org.chromium.chrome.browser.widget.TintedImageButton; | 20 import org.chromium.chrome.browser.widget.TintedImageButton; |
21 import org.chromium.chrome.browser.widget.selection.SelectableItemView; | 21 import org.chromium.chrome.browser.widget.selection.SelectableItemView; |
22 import org.chromium.components.bookmarks.BookmarkId; | 22 import org.chromium.components.bookmarks.BookmarkId; |
23 import org.chromium.ui.base.DeviceFormFactor; | |
23 | 24 |
24 import java.util.List; | 25 import java.util.List; |
25 | 26 |
26 /** | 27 /** |
27 * Common logic for bookmark and folder rows. | 28 * Common logic for bookmark and folder rows. |
28 */ | 29 */ |
29 abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo kmarkUIObserver { | 30 abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo kmarkUIObserver { |
30 | 31 |
31 protected ImageView mIconImageView; | 32 protected ImageView mIconImageView; |
32 protected TextView mTitleView; | 33 protected TextView mTitleView; |
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
179 if (isSelectable()) { | 180 if (isSelectable()) { |
180 mMoreIcon = (TintedImageButton) findViewById(R.id.more); | 181 mMoreIcon = (TintedImageButton) findViewById(R.id.more); |
181 mMoreIcon.setVisibility(VISIBLE); | 182 mMoreIcon.setVisibility(VISIBLE); |
182 mMoreIcon.setOnClickListener(new OnClickListener() { | 183 mMoreIcon.setOnClickListener(new OnClickListener() { |
183 @Override | 184 @Override |
184 public void onClick(View view) { | 185 public void onClick(View view) { |
185 showMenu(view); | 186 showMenu(view); |
186 } | 187 } |
187 }); | 188 }); |
188 } | 189 } |
190 | |
191 if (isSelectable() && !DeviceFormFactor.isLargeTablet(getContext())) { | |
gone
2017/02/17 01:45:02
Is this only called for two out of the three possi
Theresa
2017/02/17 17:34:28
I added some comments. This is temporary, until bo
| |
192 setLateralMarginsForDefaultDisplay(findViewById(R.id.bookmark_row)); | |
193 } | |
189 } | 194 } |
190 | 195 |
191 @Override | 196 @Override |
192 protected void onAttachedToWindow() { | 197 protected void onAttachedToWindow() { |
193 super.onAttachedToWindow(); | 198 super.onAttachedToWindow(); |
194 mIsAttachedToWindow = true; | 199 mIsAttachedToWindow = true; |
195 if (mDelegate != null) { | 200 if (mDelegate != null) { |
196 initialize(); | 201 initialize(); |
197 } | 202 } |
198 } | 203 } |
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
245 | 250 |
246 @Override | 251 @Override |
247 public void onDestroy() { | 252 public void onDestroy() { |
248 cleanup(); | 253 cleanup(); |
249 } | 254 } |
250 | 255 |
251 @Override | 256 @Override |
252 public void onFolderStateSet(BookmarkId folder) { | 257 public void onFolderStateSet(BookmarkId folder) { |
253 } | 258 } |
254 | 259 |
260 @Override | |
261 public void setBackgroundResourceForGroupPosition( | |
262 boolean isFirstInGroup, boolean isLastInGroup) { | |
263 if (DeviceFormFactor.isLargeTablet(getContext()) || !isSelectable()) ret urn; | |
gone
2017/02/17 01:45:02
Leave a comment here about why it's not doing anyt
Theresa
2017/02/17 17:34:28
I added comments in other places and extracted thi
| |
264 super.setBackgroundResourceForGroupPosition(isFirstInGroup, isLastInGrou p); | |
265 } | |
255 } | 266 } |
OLD | NEW |