[List UI Unification] Basic list unification for phones

chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.bookmarks;
 
 import android.content.Context;
 import android.util.AttributeSet;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.AdapterView;
 import android.widget.AdapterView.OnItemClickListener;
 import android.widget.ArrayAdapter;
 import android.widget.ImageView;
 import android.widget.ListPopupWindow;
 import android.widget.TextView;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
 import org.chromium.chrome.browser.widget.TintedImageButton;
 import org.chromium.chrome.browser.widget.selection.SelectableItemView;
 import org.chromium.components.bookmarks.BookmarkId;
+import org.chromium.ui.base.DeviceFormFactor;
 
 import java.util.List;
 
 /**
  * Common logic for bookmark and folder rows.
  */
 abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements BookmarkUIObserver {
 
     protected ImageView mIconImageView;
     protected TextView mTitleView;
@@ skipping 146 matching lines @@
         if (isSelectable()) {
             mMoreIcon = (TintedImageButton) findViewById(R.id.more);
             mMoreIcon.setVisibility(VISIBLE);
             mMoreIcon.setOnClickListener(new OnClickListener() {
                 @Override
                 public void onClick(View view) {
                     showMenu(view);
                 }
             });
         }
+
+        if (isSelectable() && !DeviceFormFactor.isLargeTablet(getContext())) {

[gone, 2017/02/17 01:45:02]

Is this only called for two out of the three possible layouts?  It seems like
something that should be explicitly called by super.onFinishInflate().  Granted,
they look ever so slightly different :/

[Theresa, 2017/02/17 17:34:28]

I added some comments. This is temporary, until bookmarks and downloads are
width constrained to 600dp and use the list item backgrounds on tablets. Once
that happens, we'll use a MarginResizer here similar to history. For now, the
lateral margins need to be set to hide the shadows.

+            setLateralMarginsForDefaultDisplay(findViewById(R.id.bookmark_row));
+        }
     }
 
     @Override
     protected void onAttachedToWindow() {
         super.onAttachedToWindow();
         mIsAttachedToWindow = true;
         if (mDelegate != null) {
             initialize();
         }
     }
@@ skipping 46 matching lines @@
 
     @Override
     public void onDestroy() {
         cleanup();
     }
 
     @Override
     public void onFolderStateSet(BookmarkId folder) {
     }
 
+    @Override
+    public void setBackgroundResourceForGroupPosition(
+            boolean isFirstInGroup, boolean isLastInGroup) {
+        if (DeviceFormFactor.isLargeTablet(getContext()) || !isSelectable()) return;

[gone, 2017/02/17 01:45:02]

Leave a comment here about why it's not doing anything?  Do you have to worry
about the View being rebound for something else that is suddenly not selectable?

[Theresa, 2017/02/17 17:34:28]

I added comments in other places and extracted this check into a variable that
makes it more obvious what we're checking for.
No. BookmarkSearchRow, a subclass of BookmarkRow, is not selectable. Since
isSelectable() is a property of the item view rather than the item, there's no
possibility of rebinding causing isSelectable() to change.


I do, however, have to worry about updating the background drawable if items are
removed.

+        super.setBackgroundResourceForGroupPosition(isFirstInGroup, isLastInGroup);
+    }
 }