Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4141)

Unified Diff: chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc

Issue 27034009: Implement Google network speech synthesis (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert change to register_engine for now, rebase for relanding Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
diff --git a/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc b/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
index bed4937db5e5cfb44a80a2c63e2f473a5d50ae18..e18c594496acca0debc09248641d16abede3450a 100644
--- a/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
+++ b/chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
@@ -29,7 +29,8 @@ struct TtsVoices : public Extension::ManifestData {
} // namespace
-TtsVoice::TtsVoice() {}
+TtsVoice::TtsVoice() : remote(false) {}
+
TtsVoice::~TtsVoice() {}
// static
@@ -95,6 +96,13 @@ bool TtsEngineManifestHandler::Parse(Extension* extension, string16* error) {
return false;
}
}
+ if (one_tts_voice->HasKey(keys::kTtsVoicesRemote)) {
+ if (!one_tts_voice->GetBoolean(
+ keys::kTtsVoicesRemote, &voice_data.remote)) {
+ *error = ASCIIToUTF16(errors::kInvalidTtsVoicesRemote);
+ return false;
+ }
+ }
if (one_tts_voice->HasKey(keys::kTtsVoicesEventTypes)) {
const base::ListValue* event_types_list;
if (!one_tts_voice->GetList(
« no previous file with comments | « chrome/common/extensions/api/speech/tts_engine_manifest_handler.h ('k') | chrome/common/extensions/api/system_private.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698