chrome/browser/speech/extension_api/tts_extension_api.cc - Issue 27034009: Implement Google network speech synthesis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api.cc

Issue 27034009: Implement Google network speech synthesis (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert change to register_engine for now, rebase for relanding Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/speech/extension_api/tts_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_api.cc b/chrome/browser/speech/extension_api/tts_extension_api.cc

index 6523b4eaf8c611cf0b9ad389b8ed588380a74fca..14c56411ea5a13a2b6b9aad21aada4b30820a842 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_api.cc

@@ -307,6 +307,7 @@ bool TtsGetVoicesFunction::RunImpl() {

const VoiceData& voice = voices[i];

DictionaryValue* result_voice = new DictionaryValue();

result_voice->SetString(constants::kVoiceNameKey, voice.name);

+ result_voice->SetBoolean(constants::kRemoteKey, voice.remote);

if (!voice.lang.empty())

result_voice->SetString(constants::kLangKey, voice.lang);

if (voice.gender == TTS_GENDER_MALE)