Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: media/capture/video/video_capture_device_descriptor.cc

Issue 2703393007: Show meaningful name for cameras (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_device_descriptor.cc
diff --git a/media/capture/video/video_capture_device_descriptor.cc b/media/capture/video/video_capture_device_descriptor.cc
index 701160846ac8924d1947af6009500be4328ea776..0fcbf91bc77e84a1cd7545358899665b66ec4c2b 100644
--- a/media/capture/video/video_capture_device_descriptor.cc
+++ b/media/capture/video/video_capture_device_descriptor.cc
@@ -5,6 +5,8 @@
#include "media/capture/video/video_capture_device_descriptor.h"
#include "base/logging.h"
+#include "extensions/strings/grit/extensions_strings.h"
+#include "ui/base/l10n/l10n_util.h"
namespace media {
@@ -94,4 +96,23 @@ std::string VideoCaptureDeviceDescriptor::GetNameAndModel() const {
return display_name + " (" + model_id + ")";
}
+std::string VideoCaptureDeviceDescriptor::GetHumanReadableName() const {
+ std::string facing_info;
+ switch (facing) {
+ case MEDIA_VIDEO_FACING_USER:
+ facing_info = l10n_util::GetStringUTF8(IDS_CAMERA_FACING_USER);
+ break;
+ case MEDIA_VIDEO_FACING_ENVIRONMENT:
+ facing_info = l10n_util::GetStringUTF8(IDS_CAMERA_FACING_ENVIRONMENT);
+ break;
+ case MEDIA_VIDEO_FACING_NONE:
+ case NUM_MEDIA_VIDEO_FACING_MODES:
+ break;
+ }
+
+ if (facing_info.empty())
+ return GetNameAndModel();
+ return GetNameAndModel() + " (" + facing_info + ")";
+}
+
} // namespace media
« media/capture/video/DEPS ('K') | « media/capture/video/video_capture_device_descriptor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698