chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h - Issue 2703393007: Show meaningful name for cameras

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h

Issue 2703393007: Show meaningful name for cameras (Closed)

Patch Set: fix trybot Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/media_devices_selection_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h

diff --git a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h

index 2bd009b2ea0e8523b48351e73c95fe4ac9b75b48..9d0863b955afacf9ffed7c0b37c8bfb78e6f8ab1 100644

--- a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h

+++ b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h

@@ -51,6 +51,10 @@ class MediaDevicesSelectionHandler

void UpdateDevicesMenu(DeviceType type,

const content::MediaStreamDevices& devices);

+ // Gets the human readable name of the device.

+ std::string GetDeviceDisplayName(

+ const content::MediaStreamDevice& device) const;

Profile* profile_; // Weak pointer.

ScopedObserver<MediaCaptureDevicesDispatcher,