media/capture/video/DEPS - Issue 2703393007: Show meaningful name for cameras

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/capture/video/DEPS

Issue 2703393007: Show meaningful name for cameras (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+extensions/strings/grit/extensions_strings.h",
	mtomasz 2017/02/27 01:27:36 This dependency looks bad. Media shouldn't depend This dependency looks bad. Media shouldn't depend on extensions and UI. I know I suggested l10util earlier, but I don't think it's right. Could we move the translation to somewhere higher, eg. https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/setting... shenghao 2017/03/02 07:20:13 Done. Show quoted text On 2017/02/27 01:27:36, mtomasz wrote: > This dependency looks bad. Media shouldn't depend on extensions and UI. I know I > suggested l10util earlier, but I don't think it's right. > > Could we move the translation to somewhere higher, eg. > https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/setting... Done.
2 "+mojo/public/cpp",	3 "+mojo/public/cpp",

3 "+third_party/libyuv",	4 "+third_party/libyuv",

	5 "+ui/base/l10n/l10n_util.h",

4 ]	6 ]

OLD	NEW

« no previous file with comments | « media/capture/BUILD.gn ('k') | media/capture/video/video_capture_device_descriptor.h » ('j') | no next file with comments »