Show meaningful name for cameras

media/capture/video/video_capture_device_descriptor.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/video_capture_device_descriptor.h"
 
 #include "base/logging.h"
 
+namespace {
+
+const char* VIDEO_FACING_STRINGS[media::NUM_MEDIA_VIDEO_FACING_MODE] = {
+    "", "user-facing", "world-facing"};

[mcasas, 2017/02/22 19:03:59]

nit: move the anonymous namespace inside media, 
 s/VIDEO_FACING_STRINGS/kVideoFacingNames/
and s/"world-facing"/"environment-facing"/
to comply with 
https://www.w3.org/TR/mediacapture-streams/#idl-def-VideoFacingModeEnum

[shenghao, 2017/02/24 01:11:39]

Deleted

+}
+
 namespace media {
 
 VideoCaptureDeviceDescriptor::VideoCaptureDeviceDescriptor()
     : facing(VideoFacingMode::MEDIA_VIDEO_FACING_NONE),
       capture_api(VideoCaptureApi::UNKNOWN),
       transport_type(VideoCaptureTransportType::OTHER_TRANSPORT) {}
 
 VideoCaptureDeviceDescriptor::VideoCaptureDeviceDescriptor(
     const std::string& display_name,
     const std::string& device_id,
@@ skipping 68 matching lines @@
       return "Unknown API";
   }
 }
 
 std::string VideoCaptureDeviceDescriptor::GetNameAndModel() const {
   if (model_id.empty())
     return display_name;
   return display_name + " (" + model_id + ")";
 }
 
+std::string VideoCaptureDeviceDescriptor::GetHumanReadableName() const {
+  std::string facing_info(VIDEO_FACING_STRINGS[facing]);
+  if (facing_info.empty()) {
+    return GetNameAndModel();
+  }

[mcasas, 2017/02/22 19:03:59]

nit: no {} for one-line bodies.

[shenghao, 2017/02/24 01:11:39]

Done.

+  return GetNameAndModel() + " (" + facing_info + ")";

[mtomasz, 2017/02/22 03:20:37]

If human readable, then should we localize? If hard to localize here, then maybe
easier to localize in UI (settings). In such case, maybe GetHumanReadableName is
not needed at all.

[tommi (sloooow) - chröme, 2017/02/22 10:41:04]

I don't think we have a way of knowing what language the name and model will be
in and these names are not localized by us.  Hmm... given that, is adding the
facing info to the label, is useful or if it will be confusing for users?

[shenghao, 2017/02/24 01:11:39]

Replied in previous comment.

+}
+
 }  // namespace media