Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: tests/co19/co19-runtime.status

Issue 2703383002: [Gardening] Mark time-dependent spawn tests flaky on all vm configurations (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/co19/co19-runtime.status
diff --git a/tests/co19/co19-runtime.status b/tests/co19/co19-runtime.status
index 70437609d7aea99890bfe7532c0c39443bad5ec5..eadde1bc1805816b351c8f4823717316a3fa4469 100644
--- a/tests/co19/co19-runtime.status
+++ b/tests/co19/co19-runtime.status
@@ -2,11 +2,18 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
+[ $runtime == vm ]
+# These tests are timing dependent and should be non-flaky once the fix for
+# https://github.com/dart-lang/co19/issues/86 is merged into master.
+# (They are skipped on $runtime == pre_compiled below.)
+LibTest/isolate/Isolate/spawnUri_A01_t06: Pass, Fail # Issue 28269
+LibTest/isolate/Isolate/spawnUri_A01_t07: Pass, Fail # Issue 28269
+LibTest/isolate/Isolate/spawn_A04_t01: Pass, Fail # Issue 28269
+
[$runtime == vm && $compiler == none && $system == fuchsia]
*: Skip # Tests not included in the image.
[ $runtime == vm || $runtime == dart_precompiled ]
-
# Failures ok in tests below. VM moves super initializer to end of list.
Language/Classes/Constructors/Generative_Constructors/execution_t03: Fail, OK
Language/Expressions/Instance_Creation/New/execution_t04: Fail, OK
@@ -53,8 +60,6 @@ Language/Libraries_and_Scripts/Parts/syntax_t06: Fail
[ ($runtime == vm || $runtime == dart_precompiled ) && $mode == debug ]
LibTest/core/List/List_class_A01_t02: Pass, Slow
-LibTest/isolate/Isolate/spawn_A04_t01: Pass, Fail # Issue 28269
-LibTest/isolate/Isolate/spawnUri_A01_t07: Pass, Fail # Issue 28269
[ ($runtime == vm || $runtime == dart_precompiled) && ($arch != x64 && $arch != simarm64 && $arch != arm64 && $arch != simdbc64 && $arch != simdbc) ]
LibTest/core/int/operator_left_shift_A01_t02: Fail # co19 issue 129
@@ -217,8 +222,6 @@ LibTest/core/Map/Map_class_A01_t04: Pass, Timeout
LibTest/core/Uri/Uri_A06_t03: Pass, Timeout
LibTest/core/Uri/encodeQueryComponent_A01_t02: Pass, Timeout
LibTest/isolate/Isolate/spawn_A01_t04: Pass, Timeout
-LibTest/isolate/Isolate/spawnUri_A01_t06: Pass, Fail # Timing dependent
-LibTest/isolate/Isolate/spawnUri_A01_t07: Pass, Fail # Timing dependent
LibTest/isolate/ReceivePort/take_A01_t02: Skip # Issue 27773
[ $runtime == vm && $mode == release && $system == linux && ($arch == x64 || $arch == ia32)]
@@ -226,6 +229,3 @@ LibTest/isolate/Isolate/spawn_A04_t05: Pass, Slow
[ $runtime == vm && $mode == release && $system == linux && $arch == ia32]
service/dev_fs_spawn_test: Pass, Fail # Issue 28411
-
-[ $runtime == vm && $system == linux && ($arch == x64 || $arch == ia32) ]
-co19/LibTest/isolate/Isolate/spawnUri_A01_t06: Pass, Fail # Issue 28269
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698