Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2703373010: Change Library service protocol ids (Closed)

Created:
3 years, 10 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
turnidge, rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Library service protocol ids Switch the service protocol id for a Library from: "/libraries/<library_table_index>" to: "/libraries/<library_private_key>" The library table index is not stable across reloads but library ids are expected to be stable. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/08769082fbf62864f2e2c273fc0a06bd6265adfe

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M runtime/vm/debugger_test.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/object_service.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
3 years, 10 months ago (2017-02-23 22:42:52 UTC) #3
rmacnak
LGTM (The language really identifies libraries by their URIs, but the private keys will be ...
3 years, 10 months ago (2017-02-24 03:20:27 UTC) #4
Cutch
3 years, 9 months ago (2017-02-24 17:50:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
08769082fbf62864f2e2c273fc0a06bd6265adfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698