third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Addressed comments from kinuko and haraken Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index c7e8b5b33844e27bd80aced8b8bb71899f7eec8f..02ba59ee787f700515ce5c86251d0bcb491d69fc 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -331,7 +331,7 @@ void ServiceWorkerGlobalScopeProxy::DispatchForeignFetchEvent(

// TODO(mek): Ideally the browser wouldn't even start the service worker

// if its tokens have expired.

ServiceWorkerGlobalScopeClient::From(WorkerGlobalScope())

- ->RespondToFetchEvent(fetch_event_id, WTF::CurrentTime());

+ ->RespondToFetchEventWithNoResponse(fetch_event_id, WTF::CurrentTime());

ServiceWorkerGlobalScopeClient::From(WorkerGlobalScope())

->DidHandleFetchEvent(fetch_event_id,

kWebServiceWorkerEventResultCompleted,