third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Addressed comments from kinuko and haraken Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index 9928ce7689db0e84bea8aa6066919a7d85ce864e..ddf2ea7a3237716a00bff43b0a2b5b85c0e55ad0 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -81,12 +81,17 @@ class ServiceWorkerGlobalScopeClientImpl final

void DidHandleExtendableMessageEvent(int event_id,

WebServiceWorkerEventResult,

double event_dispatch_time) override;

- void RespondToFetchEvent(int response_id,

- double event_dispatch_time) override;

- void RespondToFetchEvent(int response_id,

+ void RespondToFetchEventWithNoResponse(int fetch_event_id,

+ double event_dispatch_time) override;

+ void RespondToFetchEvent(int fetch_event_id,

const WebServiceWorkerResponse&,

double event_dispatch_time) override;

- void RespondToPaymentRequestEvent(int response_id,

+ void RespondToFetchEventWithResponseStream(

+ int fetch_event_id,

+ const WebServiceWorkerResponse&,

+ WebServiceWorkerStreamHandle*,

+ double event_dispatch_time) override;

+ void RespondToPaymentRequestEvent(int event_id,

const WebPaymentAppResponse&,

double event_dispatch_time) override;

void DidHandleFetchEvent(int fetch_event_id,