third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Addressed comments from kinuko and haraken Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/Source/platform/exported/WebServiceWorkerStreamHandle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp b/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp

index f0011dc3d17aefbe654495aaf63fa78b1a113934..a322c00d2f058f86de2c9158c651765dcd57d10d 100644

--- a/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp

@@ -26,7 +26,6 @@ class WebServiceWorkerResponsePrivate

WebServiceWorkerResponseType response_type;

HTTPHeaderMap headers;

RefPtr<BlobDataHandle> blob_data_handle;

- WebURL stream_url;

WebServiceWorkerResponseError error;

int64_t response_time;

WebString cache_storage_cache_name;

@@ -128,14 +127,6 @@ uint64_t WebServiceWorkerResponse::BlobSize() const {

return private_->blob_data_handle->size();

}

-void WebServiceWorkerResponse::SetStreamURL(const WebURL& url) {

- private_->stream_url = url;

-const WebURL& WebServiceWorkerResponse::StreamURL() const {

- return private_->stream_url;

void WebServiceWorkerResponse::SetError(WebServiceWorkerResponseError error) {

private_->error = error;

}