third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Addressed comments from kinuko and haraken Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 62e04e1a1a19efd5014f7f3415db9f4e8e3490b8..5373e4a0b1b8d284033f78faf66d28102b9dcea3 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -42,6 +42,7 @@

#include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerEventResult.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h"

+#include "public/platform/modules/serviceworker/WebServiceWorkerStreamHandle.h"

namespace blink {

@@ -96,13 +97,17 @@ class MODULES_EXPORT ServiceWorkerGlobalScopeClient

virtual void DidHandleExtendableMessageEvent(int event_id,

WebServiceWorkerEventResult,

double event_dispatch_time) = 0;

- // Calling respondToFetchEvent without response means no response was

- // provided by the service worker in the fetch events, so fallback to native.

- virtual void RespondToFetchEvent(int fetch_event_id,

- double event_dispatch_time) = 0;

+ virtual void RespondToFetchEventWithNoResponse(

+ int fetch_event_id,

+ double event_dispatch_time) = 0;

virtual void RespondToFetchEvent(int fetch_event_id,

const WebServiceWorkerResponse&,

double event_dispatch_time) = 0;

+ virtual void RespondToFetchEventWithResponseStream(

+ int fetch_event_id,

+ const WebServiceWorkerResponse&,

+ WebServiceWorkerStreamHandle*,

+ double event_dispatch_time) = 0;

virtual void RespondToPaymentRequestEvent(int event_id,

const WebPaymentAppResponse&,

double event_dispatch_time) = 0;