Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: content/browser/cache_storage/cache_storage_cache.cc

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)
Patch Set: Addressed comments from kinuko and haraken Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/DEPS ('k') | content/browser/cache_storage/cache_storage_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/cache_storage/cache_storage_cache.cc
diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc
index 4bb7598563e052374ff273ecd77c91e66c4ee5f7..9a4a02e6d224190a8c369e2aee3a28709ca1bc34 100644
--- a/content/browser/cache_storage/cache_storage_cache.cc
+++ b/content/browser/cache_storage/cache_storage_cache.cc
@@ -240,8 +240,7 @@ std::unique_ptr<ServiceWorkerResponse> CreateResponse(
std::move(url_list), metadata.response().status_code(),
metadata.response().status_text(),
ProtoResponseTypeToWebResponseType(metadata.response().response_type()),
- std::move(headers), "", 0, GURL(),
- blink::kWebServiceWorkerResponseErrorUnknown,
+ std::move(headers), "", 0, blink::kWebServiceWorkerResponseErrorUnknown,
base::Time::FromInternalValue(metadata.response().response_time()),
true /* is_in_cache_storage */, cache_name,
base::MakeUnique<ServiceWorkerHeaderList>(
@@ -1017,9 +1016,6 @@ void CacheStorageCache::Put(const CacheStorageBatchOperation& operation,
operation.request.headers, operation.request.referrer,
operation.request.is_reload));
- // We don't support streaming for cache.
- DCHECK(operation.response.stream_url.is_empty());
-
std::unique_ptr<ServiceWorkerResponse> response =
base::MakeUnique<ServiceWorkerResponse>(operation.response);
std::unique_ptr<storage::BlobDataHandle> blob_data_handle;
« no previous file with comments | « content/browser/DEPS ('k') | content/browser/cache_storage/cache_storage_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698