Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)
Patch Set: Addressed falken's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
index 4b8c565edbc49ab90c28183cf91ca6a8bc4c2700..ad7aa902d674211e3aa8833e8631f433cf290d02 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
@@ -39,6 +39,7 @@
#include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerEventResult.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h"
+#include "public/platform/modules/serviceworker/WebServiceWorkerStreamHandle.h"
#include "public/web/WebDevToolsAgentClient.h"
#include "v8/include/v8.h"
@@ -162,17 +163,27 @@ class WebServiceWorkerContextClient {
WebServiceWorkerEventResult result,
double event_dispatch_time) {}
- // ServiceWorker specific methods. respondFetchEvent will be called after
+ // ServiceWorker specific methods. RespondToFetchEvent* will be called after
// FetchEvent returns a response by the ServiceWorker's script context, and
- // didHandleFetchEvent will be called after the end of FetchEvent's
+ // DidHandleFetchEvent will be called after the end of FetchEvent's
// lifecycle. When no response is provided, the browser should fallback to
- // native fetch. EventIDs are the same with the ids passed from
- // dispatchFetchEvent respectively.
- virtual void RespondToFetchEvent(int fetch_event_id,
- double event_dispatch_time) {}
+ // native fetch. |fetch_event_id|s are the same with the ids passed from
+ // DispatchFetchEvent respectively.
falken 2017/04/19 06:56:52 maybe add an empty line to make clear that "Used w
shimazu 2017/04/19 08:32:16 Done.
+ // Used when respondWith() is not called. Tells the browser to fall back to
+ // native fetch.
+ virtual void RespondToFetchEventWithNoResponse(int fetch_event_id,
+ double event_dispatch_time) {}
+ // Responds to the fetch event with |response|.
virtual void RespondToFetchEvent(int fetch_event_id,
const WebServiceWorkerResponse& response,
double event_dispatch_time) {}
+ // Responds to the fetch event with |response|, where body is
+ // |body_as_stream|.
+ virtual void RespondToFetchEventWithResponseStream(
+ int fetch_event_id,
+ const WebServiceWorkerResponse& response,
+ WebServiceWorkerStreamHandle* body_as_stream,
+ double event_dispatch_time) {}
virtual void RespondToPaymentRequestEvent(
int event_id,
const WebPaymentAppResponse& response,

Powered by Google App Engine
This is Rietveld 408576698