Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: content/browser/cache_storage/cache_storage_cache.cc

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)
Patch Set: IFRAME_URL -> SCOPE Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cache_storage/cache_storage_cache.cc
diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc
index 398792fac8387ff83f173e2f5cdb9bbe4c212053..f7aa2b00ae0231383edb759a2b8b8cb59a99a14e 100644
--- a/content/browser/cache_storage/cache_storage_cache.cc
+++ b/content/browser/cache_storage/cache_storage_cache.cc
@@ -240,8 +240,7 @@ std::unique_ptr<ServiceWorkerResponse> CreateResponse(
std::move(url_list), metadata.response().status_code(),
metadata.response().status_text(),
ProtoResponseTypeToWebResponseType(metadata.response().response_type()),
- std::move(headers), "", 0, GURL(),
- blink::kWebServiceWorkerResponseErrorUnknown,
+ std::move(headers), "", 0, blink::kWebServiceWorkerResponseErrorUnknown,
base::Time::FromInternalValue(metadata.response().response_time()),
true /* is_in_cache_storage */, cache_name,
base::MakeUnique<ServiceWorkerHeaderList>(
@@ -1017,8 +1016,6 @@ void CacheStorageCache::Put(const CacheStorageBatchOperation& operation,
operation.request.headers, operation.request.referrer,
operation.request.is_reload));
- // We don't support streaming for cache.
- DCHECK(operation.response.stream_url.is_empty());
// We don't support the body of redirect response.
DCHECK(!(operation.response.response_type ==
blink::kWebServiceWorkerResponseTypeOpaqueRedirect &&

Powered by Google App Engine
This is Rietveld 408576698