third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Used TEST_P to test closing the connection first and On{Aborted,Completed} first Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/public/platform/modules/serviceworker/service_worker_stream_handle.mojom ('K') | « third_party/WebKit/public/platform/modules/serviceworker/service_worker_stream_handle.mojom ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

index f3c0adca747a27a2aa28f352c9988be2677fa6b6..db071075b59e18fae449549b1e5f60b3e8b40ede 100644

--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

@@ -39,6 +39,7 @@

#include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerEventResult.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h"

+#include "public/platform/modules/serviceworker/WebServiceWorkerStreamHandle.h"

#include "public/web/WebDevToolsAgentClient.h"

#include "v8/include/v8.h"

@@ -170,9 +171,15 @@ class WebServiceWorkerContextClient {

// dispatchFetchEvent respectively.

virtual void respondToFetchEvent(int fetchEventID, double eventDispatchTime) {

}

- virtual void respondToFetchEvent(int fetchEventID,

- const WebServiceWorkerResponse& response,

- double eventDispatchTime) {}

+ virtual void respondToFetchEventWithResponse(

+ int fetchEventID,

+ const WebServiceWorkerResponse& response,

+ double eventDispatchTime) {}

+ virtual void respondToFetchEventWithResponseStream(

+ int fetchEventID,

+ const WebServiceWorkerResponse& response,

+ WebServiceWorkerStreamHandle* streamHandle,

+ double eventDispatchTime) {}

virtual void respondToPaymentRequestEvent(

int eventId,

const WebPaymentAppResponse& response,