third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Used TEST_P to test closing the connection first and On{Aborted,Completed} first Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_event_dispatcher.mojom ('K') | « third_party/WebKit/public/BUILD.gn ('k') | third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerStreamHandle.h » ('j') | third_party/WebKit/public/platform/modules/serviceworker/service_worker_stream_handle.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

index 2b1a76f850aa9bf392aaad4d0a91529f573ea2d9..a3fa7d613554ce5e33b8e79b9b31153fe4cfa70a 100644

--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h

@@ -70,9 +70,6 @@ class BLINK_PLATFORM_EXPORT WebServiceWorkerResponse {

WebString blobUUID() const;

uint64_t blobSize() const;

- void setStreamURL(const WebURL&);

- const WebURL& streamURL() const;

// Provides a more detailed error when status() is zero.

void setError(WebServiceWorkerResponseError);

WebServiceWorkerResponseError error() const;