content/browser/service_worker/service_worker_dispatcher_host_unittest.cc - Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 2703343002: ServiceWorker: Use mojo's data pipe for respondWith(stream) (Closed)

Patch Set: Used TEST_P to test closing the connection first and On{Aborted,Completed} first Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc ('k') | content/browser/service_worker/service_worker_fetch_dispatcher.h » ('j') | content/common/service_worker/service_worker_event_dispatcher.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

index 0c3fdb678eea6b56ab493ca2eba85d61c9dd2b4d..8f8da8fa49424e7c7fd7ada55dbf1ddde4e524a8 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

@@ -830,8 +830,7 @@ TEST_F(ServiceWorkerDispatcherHostTest, ReceivedTimedOutRequestResponse) {

const int kFetchEventId = 91; // Dummy value

dispatcher_host_->OnMessageReceived(ServiceWorkerHostMsg_FetchEventResponse(

version_->embedded_worker()->embedded_worker_id(), kFetchEventId,

- SERVICE_WORKER_FETCH_EVENT_RESULT_FALLBACK, ServiceWorkerResponse(),

- base::Time::Now()));

+ ServiceWorkerResponse(), base::Time::Now()));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(0, dispatcher_host_->bad_messages_received_count_);