Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5443)

Unified Diff: chrome/unit_tests.isolate

Issue 270333002: Enable the ninja parsing code all the time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Works better Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/unit_tests.isolate
diff --git a/chrome/unit_tests.isolate b/chrome/unit_tests.isolate
index 15a24b757da4a50675b417ea5605e960af249e3b..cc51d5b1290cdf791b5297695458361d59cbad06 100644
--- a/chrome/unit_tests.isolate
+++ b/chrome/unit_tests.isolate
@@ -48,12 +48,7 @@
'isolate_dependency_tracked': [
'../testing/xvfb.py',
'<(PRODUCT_DIR)/libffmpegsumo.so',
- '<(PRODUCT_DIR)/libosmesa.so',
'<(PRODUCT_DIR)/locales/fr.pak',
Vadim Sh. 2014/05/07 18:08:34 side note: why only 'fr'? :) it looks suspicious :
M-A Ruel 2014/05/07 19:39:08 Russians are welcome to add theirs if needed.
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
- ],
- 'isolate_dependency_touched': [
- '<(PRODUCT_DIR)/libppGoogleNaClPluginChrome.so',
],
},
}],
@@ -84,7 +79,6 @@
'isolate_dependency_tracked': [
'<(PRODUCT_DIR)/exif.so',
'<(PRODUCT_DIR)/ffmpegsumo.so',
- '<(PRODUCT_DIR)/osmesa.so',
],
'isolate_dependency_untracked': [
'<(PRODUCT_DIR)/<(mac_product_name) Framework.framework/',
@@ -110,10 +104,9 @@
['OS=="win"', {
'variables': {
'isolate_dependency_tracked': [
- '<(PRODUCT_DIR)/chrome_elf.dll',
- '<(PRODUCT_DIR)/ffmpegsumo.dll',
- '<(PRODUCT_DIR)/libexif.dll',
- '<(PRODUCT_DIR)/osmesa.dll',
+ # '<(PRODUCT_DIR)/chrome_elf.dll',
Vadim Sh. 2014/05/07 18:08:34 Why not just remove it? We use source control syst
M-A Ruel 2014/05/07 19:39:08 Added back, it was an error on my part.
+ # '<(PRODUCT_DIR)/ffmpegsumo.dll',
+ # '<(PRODUCT_DIR)/libexif.dll',
],
'isolate_dependency_untracked': [
'../ppapi/lib/gl/include/KHR/',
« no previous file with comments | « base/base_unittests.isolate ('k') | tools/isolate_driver.py » ('j') | tools/ninja_parser.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698