Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Unified Diff: chrome/browser/web_applications/web_app_chromeos.cc

Issue 2703283005: Destroy web_app::ShortcutInfo on UI thread (Closed)
Patch Set: s/auto/web_app::ShortcutInfo/. +Unretained. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_chromeos.cc
diff --git a/chrome/browser/web_applications/web_app_chromeos.cc b/chrome/browser/web_applications/web_app_chromeos.cc
index 8fcd2f11016ee35cfa4f021e069b2ae63fda9606..5a0a9c877231eb674f694ff15dedd46725493147 100644
--- a/chrome/browser/web_applications/web_app_chromeos.cc
+++ b/chrome/browser/web_applications/web_app_chromeos.cc
@@ -13,20 +13,19 @@ void UpdateShortcutsForAllApps(Profile* profile,
namespace internals {
-bool CreatePlatformShortcuts(
- const base::FilePath& web_app_path,
- std::unique_ptr<ShortcutInfo> shortcut_info,
- const ShortcutLocations& creation_locations,
- ShortcutCreationReason creation_reason) {
+bool CreatePlatformShortcuts(const base::FilePath& web_app_path,
+ ShortcutInfo* shortcut_info,
+ const ShortcutLocations& creation_locations,
+ ShortcutCreationReason creation_reason) {
return true;
}
void DeletePlatformShortcuts(const base::FilePath& web_app_path,
- std::unique_ptr<ShortcutInfo> shortcut_info) {}
+ ShortcutInfo* shortcut_info) {}
void UpdatePlatformShortcuts(const base::FilePath& web_app_path,
const base::string16& old_app_title,
- std::unique_ptr<ShortcutInfo> shortcut_info) {}
+ ShortcutInfo* shortcut_info) {}
void DeleteAllShortcutsForProfile(const base::FilePath& profile_path) {}

Powered by Google App Engine
This is Rietveld 408576698