Network traffic annotation added to distiller_url_fetcher.

components/dom_distiller/core/distiller_url_fetcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/dom_distiller/core/distiller_url_fetcher.h"
 
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_status.h"
 #include "url/gurl.h"
 
 using net::URLFetcher;
 
 namespace dom_distiller {
 
@@ skipping 21 matching lines @@
   // Don't allow a fetch if one is pending.
   DCHECK(!url_fetcher_ || !url_fetcher_->GetStatus().is_io_pending());
   callback_ = callback;
   url_fetcher_ = CreateURLFetcher(context_getter_, url);
   url_fetcher_->Start();
 }
 
 std::unique_ptr<URLFetcher> DistillerURLFetcher::CreateURLFetcher(
     net::URLRequestContextGetter* context_getter,
     const std::string& url) {
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("dom_distiller", R"(
+        semantics {
+          sender: "DOM Distiller"
+          description:
+            "Chromium provides Mobile-friendly view on Android phones when the "

[noyau (Ping after 24h), 2017/02/24 09:37:28]

Please amend this comment. by either removing android or adding iOS. This code
is used on both platforms.

[Ramin Halavati, 2017/02/24 09:50:21]

Done.

+            "web page contains an article, and is not mobile-friendly. If the "
+            "user enters Mobile-friendly view, the main content would be "
+            "extracted and reflowed for better readability. DOM distiller is "
+            "the backend service for Mobile-friendly view, Reader Mode, and "
+            "Reading List."
+          trigger:
+            "User enters Mobile-friendly view, Reader Mode, or Reading List."

[noyau (Ping after 24h), 2017/02/24 09:37:28]

This trigger is incorrect on iOS. On this platform this is called on the
background as soon as a user has an entry on the reading list. And the entry can
be added from another app.

[Ramin Halavati, 2017/02/24 09:50:22]

Done.

+          data:
+            "URL of the required website resources to fetch. No user "
+            "information is sent."
+          destination: WEBSITE
+        }
+        policy {
+          cookies_allowed: true
+          cookies_store: "user"
+          setting: "Users can enable or disable Mobile-friendly view by "
+          "toggling chrome://flags#reader-mode-heuristics in Chromium on "
+          "Android."
+          policy_exception_justification:
+            "Not implemented, considered not useful as no content is being "
+            "uploaded; this request merely downloads the resources on the web."
+        })");
   std::unique_ptr<net::URLFetcher> fetcher =
-      URLFetcher::Create(GURL(url), URLFetcher::GET, this);
+      URLFetcher::Create(GURL(url), URLFetcher::GET, this, traffic_annotation);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher.get(), data_use_measurement::DataUseUserData::DOM_DISTILLER);
   fetcher->SetRequestContext(context_getter);
   static const int kMaxRetries = 5;
   fetcher->SetMaxRetriesOn5xx(kMaxRetries);
   return fetcher;
 }
 
 void DistillerURLFetcher::OnURLFetchComplete(
     const URLFetcher* source) {
   std::string response;
   if (source && source->GetStatus().is_success() &&
       source->GetResponseCode() == net::HTTP_OK) {
     // Only copy over the data if the request was successful. Insert
     // an empty string into the proto otherwise.
     source->GetResponseAsString(&response);
   }
   callback_.Run(response);
 }
 
 }  // namespace dom_distiller